Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ackGasCostDefault SUP-5371 #451

Merged
merged 6 commits into from
Jan 23, 2024
Merged

feat: add ackGasCostDefault SUP-5371 #451

merged 6 commits into from
Jan 23, 2024

Conversation

0xTimepunk
Copy link
Contributor

Draft, to be approved

Likely requires cleanup of main estimate functions not to include the ack parcel of the cost so it can be determined only via this function

@0xTimepunk 0xTimepunk changed the title feat: add ackGasCostDefault feat: add ackGasCostDefault SUP-5371 Jan 23, 2024
Copy link

linear bot commented Jan 23, 2024

@0xTimepunk 0xTimepunk requested a review from vikramarun January 23, 2024 11:01
vikramarun
vikramarun previously approved these changes Jan 23, 2024
Copy link
Contributor

@vikramarun vikramarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xTimepunk 0xTimepunk merged commit 3f63afa into develop Jan 23, 2024
6 checks passed
@0xTimepunk 0xTimepunk deleted the ackGasCostDefault branch January 23, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants